New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn memory leak when using nativeWindowOpen with nodeIntegration (3-0-x) #15192

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Oct 16, 2018

Description of Change

Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

Refs #12634, #15076 (comment).

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Oct 16, 2018

@zcbenz zcbenz added the target/2-0-x label Oct 16, 2018

@zcbenz zcbenz removed the target/2-0-x label Oct 17, 2018

@zcbenz zcbenz merged commit 6f54d58 into 3-0-x Oct 17, 2018

17 of 18 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 17, 2018

Release Notes Persisted

Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz deleted the window-open-warn-leak-3-0-x branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment