Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn memory leak when using nativeWindowOpen with nodeIntegration (3-0-x) #15192

Merged
merged 2 commits into from
Oct 17, 2018
Merged

chore: warn memory leak when using nativeWindowOpen with nodeIntegration (3-0-x) #15192

merged 2 commits into from
Oct 17, 2018

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Oct 16, 2018

Description of Change

Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

Refs #12634, #15076 (comment).

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz requested a review from a team October 16, 2018 11:16
@zcbenz zcbenz mentioned this pull request Oct 17, 2018
Merged
@zcbenz zcbenz merged commit 6f54d58 into 3-0-x Oct 17, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 17, 2018

Release Notes Persisted

Print a memory leak warning when the child windows opened with nativeWindowOpen option have node integration.

@zcbenz zcbenz deleted the window-open-warn-leak-3-0-x branch October 17, 2018 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zcbenz