-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional remote APIs filtering #16293
Conversation
b56a1f7
to
abe803e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MarshallOfSound, @nornagon can you please review? |
abe803e
to
66767db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures look relevant
66767db
to
6a2e97a
Compare
@nornagon some tests were broken after |
6a2e97a
to
39e2c85
Compare
Release Notes Persisted
|
/trop run backport-to 4-0-x |
The backport process for this PR has been manually initiated, |
I was unable to backport this PR to "4-0-x" cleanly; |
Description of Change
Follow up to #15014:
remote.getBuiltin()
by handlingremote-get-builtin
remote.getCurrentWindow()
by handlingremote-get-current-window
remote.getCurrentWebContents()
by handlingremote-get-current-web-contents
<webview>.getWebContents()
(implemented viaremote.getGuestWebContents()
) by handlingremote-get-guest-web-contents
I can be used to return a proxied or filtered version of the electron APIs.
Checklist
npm test
passesRelease Notes
Notes: Allowed filtering of
remote.getBuiltin()
,remote.getCurrentWindow()
,remote.getCurrentWebContents
and<webview>.getWebContents()
.