Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional remote APIs filtering #16293

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented Jan 7, 2019

Description of Change

Follow up to #15014:

  • remote.getBuiltin() by handling remote-get-builtin
  • remote.getCurrentWindow() by handling remote-get-current-window
  • remote.getCurrentWebContents() by handling remote-get-current-web-contents
  • <webview>.getWebContents() (implemented via remote.getGuestWebContents()) by handling remote-get-guest-web-contents

I can be used to return a proxied or filtered version of the electron APIs.

Checklist

Release Notes

Notes: Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@miniak miniak requested review from as code owners Jan 7, 2019

@miniak miniak self-assigned this Jan 7, 2019

@miniak miniak changed the title feat: add remote.getBuiltin() / remote.getCurrentWindow() / remote.getCurrentWebContents() filtering feat: add additional remote module filtering Jan 7, 2019

@miniak miniak changed the title feat: add additional remote module filtering feat: add additional remote APIs filtering Jan 7, 2019

@miniak miniak force-pushed the miniak/remote-handlers branch from b56a1f7 to abe803e Jan 7, 2019

@ppontes

ppontes approved these changes Jan 7, 2019

Copy link
Member

left a comment

LGTM

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

@MarshallOfSound, @nornagon can you please review?

@miniak miniak force-pushed the miniak/remote-handlers branch from abe803e to 66767db Jan 7, 2019

@nornagon
Copy link
Contributor

left a comment

test failures look relevant

@miniak miniak force-pushed the miniak/remote-handlers branch from 66767db to 6a2e97a Jan 7, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

@nornagon some tests were broken after nodeIntegration was disabled by default. fixed those

Show resolved Hide resolved lib/browser/rpc-server.js Outdated
Show resolved Hide resolved lib/browser/rpc-server.js Outdated
Show resolved Hide resolved spec/api-app-spec.js Outdated
Show resolved Hide resolved spec/api-app-spec.js

@miniak miniak force-pushed the miniak/remote-handlers branch from 6a2e97a to 39e2c85 Jan 8, 2019

@ckerr

ckerr approved these changes Jan 8, 2019

@nornagon nornagon merged commit 349a3c2 into master Jan 8, 2019

26 of 27 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190108.21 succeeded
Details
electron-arm64-testing Build #20190108.21 succeeded
Details
electron-lint Build #20190108.25 succeeded
Details
electron-mas-testing Build #20190108.30 succeeded
Details
electron-osx-testing Build #20190108.28 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 8, 2019

Release Notes Persisted

Allow filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@nornagon nornagon deleted the miniak/remote-handlers branch Jan 8, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

/trop run backport-to 4-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@miniak miniak referenced this pull request Mar 25, 2019

Merged

docs: add remote module to docs/tutorial/security.md #17480

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.