New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly destroy spellcheck client #16524

Merged
merged 2 commits into from Jan 25, 2019

Conversation

Projects
None yet
4 participants
@nitsakh
Copy link
Contributor

nitsakh commented Jan 24, 2019

Description of Change

Backport of #16448.

Checklist

Release Notes

Notes: Fixed memory leak caused by webFrame.setSpellCheckProvider.

@nitsakh nitsakh requested a review from electron/reviewers as a code owner Jan 24, 2019

@nitsakh nitsakh force-pushed the fix-spell-leak-4-0 branch from 34f6c73 to 7503954 Jan 24, 2019

@codebytere codebytere changed the title Fix spellcheck memory leak fix: correctly destroy spellcheck client Jan 24, 2019

@ckerr ckerr merged commit 0659093 into 4-0-x Jan 25, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 25, 2019

Release Notes Persisted

Fixed memory leak caused by webFrame.setSpellCheckProvider.

@ckerr ckerr deleted the fix-spell-leak-4-0 branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment