Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly destroy spellcheck client #16448

Merged
merged 2 commits into from Jan 24, 2019

Conversation

@nitsakh
Copy link
Contributor

commented Jan 18, 2019

Description of Change

This change addresses #15459.
The spellcheck client wasn't destroyed when the renderer goes away.
This change adds an observer which takes care of the destruction.

Checklist

Release Notes

Notes: Fixed webFrame.setSpellCheckProvider memory leak

@nitsakh nitsakh requested review from zcbenz and deepak1556 Jan 18, 2019

@nitsakh nitsakh requested a review from as a code owner Jan 18, 2019

@nitsakh

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

We should backport this to 3-0-x also, right?

@deepak1556
Copy link
Member

left a comment

LGTM with minor changes, thanks!

Show resolved Hide resolved atom/renderer/api/atom_api_web_frame.cc Outdated
Show resolved Hide resolved atom/renderer/api/atom_api_web_frame.cc Outdated
Show resolved Hide resolved atom/renderer/api/atom_api_web_frame.cc Outdated
@codebytere

This comment has been minimized.

Copy link
Member

commented Jan 19, 2019

We should backport this to 3-0-x also, right?

@nitsakh since 3-1-x went stable 3-0-x is only receiving security fixes now i believe

@nitsakh nitsakh force-pushed the fix-spell-leak branch from 0432d62 to b879de7 Jan 24, 2019

@deepak1556
Copy link
Member

left a comment

LGTM, thanks!

@codebytere codebytere changed the title fix: Destroy spellcheck client fix: correctly destroy spellcheck client Jan 24, 2019

@codebytere codebytere merged commit e6952e2 into master Jan 24, 2019

26 of 29 checks passed

Backportable? - 3-1-x Backport Failed
Details
Backportable? - 4-0-x Backport Failed
Details
electron-lint Build #20190124.3 was canceled
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20190124.3 succeeded
Details
electron-arm64-testing Build #20190124.3 succeeded
Details
electron-mas-testing Build #20190124.4 succeeded
Details
electron-osx-testing Build #20190124.4 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 24, 2019

Release Notes Persisted

Fixed webFrame.setSpellCheckProvider memory leak

@codebytere codebytere deleted the fix-spell-leak branch Jan 24, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.