fix: correct chrome version in chrome_version.h #17218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Mar 4, 2019
codebytere
approved these changes
Mar 4, 2019
MarshallOfSound
approved these changes
Mar 4, 2019
electron-cation
bot
added
new-pr 🌱
miniak
approved these changes
Mar 4, 2019
electron-cation
bot
added
new-pr 🌱
|
Release Notes Persisted
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15275 we switched to using Chrome's auto-generated version headers instead
of hard-coding the Chrome version into this header, but that change wasn't
backported to 4-0-x and we've since rolled our Chrome dependency. This fixes
the discrepancy. We don't expect any further Chrome rolls on this branch since
M69 is out of Chrome's support window.
npm testpassesNotes: Fixed
process.versions.chromereporting the wrong patch version.