Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct chrome version in chrome_version.h #17218

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
6 participants
@nornagon
Copy link
Contributor

nornagon commented Mar 4, 2019

In #15275 we switched to using Chrome's auto-generated version headers instead
of hard-coding the Chrome version into this header, but that change wasn't
backported to 4-0-x and we've since rolled our Chrome dependency. This fixes
the discrepancy. We don't expect any further Chrome rolls on this branch since
M69 is out of Chrome's support window.

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Notes: Fixed process.versions.chrome reporting the wrong patch version.

@nornagon nornagon requested a review from as a code owner Mar 4, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Mar 4, 2019

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Mar 4, 2019

@miniak

miniak approved these changes Mar 4, 2019

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Mar 4, 2019

@nornagon nornagon merged commit 3c0d90e into 4-0-x Mar 4, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 4, 2019

Release Notes Persisted

Fixed process.versions.chrome reporting the wrong patch version.

@nornagon nornagon deleted the update-chrome-version branch Mar 4, 2019

@bpasero

This comment has been minimized.

Copy link
Contributor

bpasero commented Mar 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.