Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node to v12.8.0 (master) #19726

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 13, 2019

Backport of #19521

See that PR for details.

Notes: Updated Node.js to v12.8.0.

electron-bot and others added 8 commits August 13, 2019 00:29
Removed patches that are no longer necessary because we've upstreamed few changes already, and 3 way merge others
Removed patches that are no longer necessary because we've upstreamed few changes already, and 3 way merge others
The original node commit contains changes/calls to functions that are not supported in boringssl.
@trop trop bot requested a review from a team as a code owner August 13, 2019 00:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2019
@trop trop bot added 7-0-x backport This is a backport PR labels Aug 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2019
@MarshallOfSound
Copy link
Member

This will be the final minor node bump in the 7.x series

@MarshallOfSound MarshallOfSound merged commit a905259 into 7-0-x Aug 13, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 13, 2019

Release Notes Persisted

Updated Node.js to v12.8.0.

@MarshallOfSound MarshallOfSound deleted the trop/7-0-x-bp-chore-bump-node-to-v12-8-0-master--1565656183720 branch August 13, 2019 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants