fix for Window hidden behind taskbar after maximize #7672 #7765

liusy182 · 2016-10-27T09:18:17Z

Fix for issue #7672
This bug is because boolean thick_frame_ is not updated in line with windows style WS_THICKFRAME. NativeWindowViews::Maxmize() uses a different routine when it finds thick_frame_ is not set.

levrik · 2016-10-29T21:50:19Z

atom/browser/native_window_views.cc

    FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);
+    thick_frame_ = !thick_frame_;


If this flag only gets reversed if it's true would it possibly better to set it explicitly to false?

zeke · 2016-10-30T05:30:47Z

Kicked off another Appveyor build, in case it was a flaky failure.

kevinsawicki · 2016-10-31T17:19:51Z

atom/browser/native_window_views.cc

    FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);
+    thick_frame_ = false;


I'm not sure this is the right approach here, calling setResizable twice, first with false and then with true will not re-enable the thick frame style so window animations won't work as expected.

Another approach could be to check the window style instead of thick_frame_ other places so that custom logic for maximize/unmaximize checks something like has_thick_frame() instead of thick_frame_ directly.

kevinsawicki

Window style should be checked instead of initial thick frame setting.

liusy182 · 2016-11-03T04:23:25Z

@kevinsawicki I was experimenting and noticed that we cannot replace all existing thick_frame_ check with style check on WS_THICKFRAME. The reason is that when an app is in full screen mode, WS_THICKFRAME is removed automatically. It is reset back when the app exits from full screen. Relying on WS_THICKFRAME causes issue when toggling full screen.
I think the solution is to still rely on thick_frame_, but this value will be updated with SetResizable call.

kevinsawicki · 2016-11-03T16:29:55Z

atom/browser/native_window_views.cc

@@ -571,8 +571,8 @@ void NativeWindowViews::SetContentSizeConstraints(

 void NativeWindowViews::SetResizable(bool resizable) {
 #if defined(OS_WIN)
-  if (thick_frame_)
-    FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);
+  FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);


If you create a window with thickFrame option set to false, won't this enable it the first time you call setResizable with true?

liusy182 · 2016-11-08T07:38:30Z

Thanks @kevinsawicki I realized that I did not consider the case of frameless window at all. Corrected now.

zeke · 2016-11-09T17:50:29Z

atom/browser/native_window_views.cc

@@ -571,8 +571,9 @@ void NativeWindowViews::SetContentSizeConstraints(

 void NativeWindowViews::SetResizable(bool resizable) {
 #if defined(OS_WIN)
-  if (thick_frame_)
+  if(has_frame()) {


This if needs a space after it.

atom/browser/native_window_views.cc:574: Missing space before ( in if( [whitespace/parens] [5]

(That is what is causing the current CI failure)

liusy182 · 2016-12-06T03:18:57Z

@kevinsawicki I have made requested changes. Please let me know if anything else is needed :)

kevinsawicki · 2016-12-06T18:09:44Z

I have made requested changes. Please let me know if anything else is needed :)

Sorry about the delay, just need to test this out and then I'll merge it 👍

kevinsawicki · 2016-12-13T17:09:13Z

@liusy182 sorry for the delay, I tried out the this branch and am still seeing an issue, can you confirm?

With the following app, I'm seeing the window expand over the taskbar when maximized.

const {app, BrowserWindow} = require('electron')

let window

app.once('ready', function () {
  window = new BrowserWindow({
    show: true,
    frame: false
  });
  browserWindow.loadURL('about:blank')
})

Then open the dev tools in the window and run the following:

w = require('electron').remote.getCurrentWindow()
w.setResizable(false);
w.setMinimumSize(500, 500);
w.maximize();

This maximizes the window over the taskbar for me on Windows 10.

liusy182 · 2016-12-15T06:14:59Z

thanks @kevinsawicki You are right. I checked for all the places that still refer to the old thick_frame_ and made some changes:

For Maximize() and Unmaximize(), we can directly check for existence of WS_THICKFRAME.
For SetFullScreen(bool), I found that we do not need to make special treatment for no thick_frame_ case. I have tested around with that part of the code removed and it seemed to work fine for me.

kutu · 2016-12-15T11:16:48Z

is this issue related to what i have noticed?

simple app, as described @kevinsawicki

win+up, to maximize window
i see that white glow behind taskbar
then i press task bar icon to minimize the app, and then press again to bring it back, and i see that behind taskbar

after that, if i unmaximize window, and maximize it again, white glow is back

Windows7 64bit, electron prebuilt 1.4.12

kevinsawicki · 2017-01-04T21:54:41Z

atom/browser/native_window_views.cc

@@ -486,19 +486,6 @@ void NativeWindowViews::SetFullScreen(bool fullscreen) {
    NotifyWindowLeaveFullScreen();
  }

-  // For window without WS_THICKFRAME style, we can not call SetFullscreen().
-  if (!thick_frame_) {


I think this might still be needed (or some other fix).

On this branch, with the following app, the window becomes unusable once full screen state is left:

const {app, BrowserWindow} = require('electron') let browserWindow app.once('ready', function () { browserWindow = new BrowserWindow({ show: true, fullscreen: true, transparent: true, thickFrame: false }); browserWindow.loadURL(`about:blank`) })

Then open the dev tools and run:

require('electron').remote.getCurrentWindow().setFullScreen(false)

The window does resize but if you click on it, it isn't usable and will disappear from the taskbar.

Looks like this might be #6036 happening now since this block is removed.

Where do I find atom/browser/native_window_views.cc ?

kevinsawicki · 2017-01-09T17:48:00Z

Thanks for this @liusy182, I really appreciate you taking the time to look into this so thoroughly 👍

radencode · 2017-02-24T06:40:22Z

Where do I fine atom/browser/native_window_views.cc ?

radencode · 2017-02-26T19:07:17Z

@kevinsawicki @liusy182 Has the issue with the frameless window going under the task bar been fixed? I am running into the same issue right now and if you can help I would appreciate that.

fix for Window hidden behind taskbar after maximize electron#7672

c61414e

kevinsawicki self-assigned this Oct 27, 2016

levrik reviewed Oct 29, 2016

View reviewed changes

address review comments

c657186

kevinsawicki reviewed Oct 31, 2016

View reviewed changes

kevinsawicki suggested changes Oct 31, 2016

View reviewed changes

liusi added 2 commits November 1, 2016 10:20

merge changes from master

7880d37

toggle thick_frame_ along with resizable change

0e9d973

kevinsawicki reviewed Nov 3, 2016

View reviewed changes

fix review comments

a69ee76

zeke reviewed Nov 9, 2016

View reviewed changes

liusi added 2 commits November 11, 2016 17:57

fix linting error

356d052

fix linting error

00d9baa

fix fullscreen, maximize, unmaximize

b853671

kevinsawicki suggested changes Jan 4, 2017

View reviewed changes

kevinsawicki merged commit e5aad98 into electron:master Jan 9, 2017

This was referenced Jan 9, 2017

Window hidden behind taskbar after maximize #7672

Closed

Add spec for resizable frameless window #8370

Merged

This was referenced Jan 18, 2017

Restore thick frame full screen code path #8438

Merged

Oversized maximized window #8454

Closed

liusy182 deleted the maximize-fix branch August 18, 2017 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for Window hidden behind taskbar after maximize #7672 #7765

fix for Window hidden behind taskbar after maximize #7672 #7765

liusy182 commented Oct 27, 2016

levrik Oct 29, 2016

zeke commented Oct 30, 2016

kevinsawicki Oct 31, 2016

kevinsawicki left a comment

liusy182 commented Nov 3, 2016

kevinsawicki Nov 3, 2016

liusy182 commented Nov 8, 2016

zeke Nov 9, 2016

zeke Nov 9, 2016

liusy182 commented Dec 6, 2016

kevinsawicki commented Dec 6, 2016

kevinsawicki commented Dec 13, 2016

liusy182 commented Dec 15, 2016

kutu commented Dec 15, 2016

kevinsawicki Jan 4, 2017

kevinsawicki Jan 5, 2017

radencode Feb 24, 2017

kevinsawicki commented Jan 9, 2017

radencode commented Feb 24, 2017

radencode commented Feb 26, 2017

		FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);
		thick_frame_ = !thick_frame_;

		FlipWindowStyle(GetAcceleratedWidget(), resizable, WS_THICKFRAME);
		thick_frame_ = false;

fix for Window hidden behind taskbar after maximize #7672 #7765

fix for Window hidden behind taskbar after maximize #7672 #7765

Conversation

liusy182 commented Oct 27, 2016

Choose a reason for hiding this comment

zeke commented Oct 30, 2016

Choose a reason for hiding this comment

kevinsawicki left a comment

Choose a reason for hiding this comment

liusy182 commented Nov 3, 2016

Choose a reason for hiding this comment

liusy182 commented Nov 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liusy182 commented Dec 6, 2016

kevinsawicki commented Dec 6, 2016

kevinsawicki commented Dec 13, 2016

liusy182 commented Dec 15, 2016

kutu commented Dec 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinsawicki commented Jan 9, 2017

radencode commented Feb 24, 2017

radencode commented Feb 26, 2017