Support calling remote setters with remote objects #9101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
wrap-remote-set-as-args
branch
from
b2f0336 to
fdd3633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #9023 that you couldn't call a remote setter with a remote object in the same way you can pass a remote object to a remote function call.
This was because the raw value was passed over IPC instead of a wrapped value that supported all the types (like
remote-object).This pull request switches the
ELECTRON_BROWSER_MEMBER_SETchannel to marshall/unmarshall the value being set the same as an argument to a remote function call.