New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calling remote setters with remote objects #9101

Merged
merged 4 commits into from Apr 4, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Apr 3, 2017

Noticed while working on #9023 that you couldn't call a remote setter with a remote object in the same way you can pass a remote object to a remote function call.

This was because the raw value was passed over IPC instead of a wrapped value that supported all the types (like remote-object).

This pull request switches the ELECTRON_BROWSER_MEMBER_SET channel to marshall/unmarshall the value being set the same as an argument to a remote function call.

@kevinsawicki kevinsawicki merged commit 3c1a372 into master Apr 4, 2017

7 of 9 checks passed

electron-win-x64 Build #2777 failed in 11 min
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6107538 succeeded in 74s
Details
electron-linux-ia32 Build #6107539 succeeded in 66s
Details
electron-linux-x64 Build #6107540 succeeded in 153s
Details
electron-mas-x64 Build #3816 succeeded in 8 min 13 sec
Details
electron-osx-x64 Build #3814 succeeded in 8 min 58 sec
Details
electron-win-ia32 Build #2806 succeeded in 8 min 15 sec
Details

@kevinsawicki kevinsawicki deleted the wrap-remote-set-as-args branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment