Skip to content

Conversation

@piotrpdev
Copy link
Contributor

Depends on: #80
Resolves: #79

Throws error if comments are present.

@dsanders11 @erickzhao @VerteDinde

@piotrpdev piotrpdev added ✨ enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 7, 2024
@piotrpdev piotrpdev requested a review from a team as a code owner August 7, 2024 00:28
@dsanders11 dsanders11 marked this pull request as draft August 9, 2024 00:50
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but marking this as draft until #80 is ready to merge. We can have them both go out in one release if we merge them one after the other before the first release completes.

@dsanders11 dsanders11 changed the base branch from main to feat/check-descriptions August 9, 2024 23:19
@dsanders11 dsanders11 marked this pull request as ready for review August 9, 2024 23:22
Base automatically changed from feat/check-descriptions to main August 9, 2024 23:25
@dsanders11 dsanders11 merged commit 3d87b7b into main Aug 9, 2024
@dsanders11 dsanders11 deleted the feat/disallow-comments branch August 9, 2024 23:32
@continuous-auth
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code released ✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow YAML comments in API History

3 participants