Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown expressible by underscores or asterisks after Links stopped working #20091

Closed
MTRNord opened this issue Dec 8, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7990
Closed

Markdown expressible by underscores or asterisks after Links stopped working #20091

MTRNord opened this issue Dec 8, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#7990
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@MTRNord
Copy link
Contributor

MTRNord commented Dec 8, 2021

Steps to reproduce

  1. Try sending this message: Found another wikidata gem: According to https://www.wikidata.org/wiki/Q59209813 Fractal is a _FORK_ of Matrix... as well as being based on it. :D It uses the https://www.wikidata.org/wiki/Property:P144 property which describes forks :D not usage (Using the original message as I am not sure what causes it. It may be markdown in the middle of 2 links but it may be something else as well?)

Outcome

What did you expect?

_FORK_ should get italic in the message

What happened instead?

_FORK_ did not change and the underscores show up in the timeline

Operating system

Windows 11

Browser information

Firefox 94.0.2 (64-bit)

URL for webapp

develop.element.io

Application version

Version von Element: b0abbfa-react-97ee25126fb7-js-2206b80e65aa Version von Olm: 3.2.3

Homeserver

nordgedanken.dev

Will you send logs?

No
@MTRNord
Copy link
Contributor Author

MTRNord commented Dec 8, 2021

@tulir mentioned to me that this may be a regression of matrix-org/matrix-react-sdk#7200

@MTRNord MTRNord changed the title Edge case with message causing the markdown of "FORK" not applying. Markdown after Links stopped working Dec 8, 2021
@tulir
Copy link
Contributor

tulir commented Dec 8, 2021 •
edited
Loading

Simpler example that reproduces the issue: https://example.com _foo_ bar

Also, https://example.com *test* _foo_ does something very weird

image

matrix-org/matrix-react-sdk#7257 is also related (it was a continuation of 7200)

@MTRNord MTRNord changed the title Markdown after Links stopped working Markdown expressible by underscores or asterisks after Links stopped working Dec 8, 2021
@germain-gg germain-gg added A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Dec 8, 2021
@germain-gg
Copy link
Contributor

Probably regressed by matrix-org/matrix-react-sdk#7200

@germain-gg germain-gg mentioned this issue Dec 8, 2021
Closed
@dkasak
Copy link
Member

dkasak commented Jan 5, 2022

Doesn't work after MXIDs either:

image

@t3chguy t3chguy mentioned this issue Jan 14, 2022
Closed
@robintown robintown mentioned this issue Jan 15, 2022
Closed
@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Jan 15, 2022 •
edited
Loading

Same with room IDs;

#20565

@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 15, 2022
@robintown robintown mentioned this issue Mar 5, 2022
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 1, 2022
@su-ex
Merge tag 'v1.10.8' into sc
2c28fa8 
* Live location sharing: live share warning in room ([\element-hq#8100](matrix-org/matrix-react-sdk#8100)).
* Add simple live share warning ([\element-hq#8066](matrix-org/matrix-react-sdk#8066)).
* extract reusable styled live beacon icon ([\element-hq#8103](matrix-org/matrix-react-sdk#8103)).
* Don't restore MemberInfo from RightPanel history when viewing a room ([\element-hq#8090](matrix-org/matrix-react-sdk#8090)). Fixes element-hq#21487.
* Allow sending files as replies as per MSC3676 ([\element-hq#8020](matrix-org/matrix-react-sdk#8020)). Fixes element-hq#7156.
* kill beacons on expiry ([\element-hq#8075](matrix-org/matrix-react-sdk#8075)).
* enable geolocation behaviour in location picker for live share type ([\element-hq#8068](matrix-org/matrix-react-sdk#8068)).
* Improve formatting features in the editor ([\#7104](matrix-org/matrix-react-sdk#7104)). Fixes element-hq#19501. Contributed by @alexanderstephan.
* Support MSC3026 busy presence ([\element-hq#8043](matrix-org/matrix-react-sdk#8043)).
* Show displayname in non-narrow thread summeries ([\element-hq#8036](matrix-org/matrix-react-sdk#8036)). Fixes element-hq#19646.
* Tweak search dialog based on new designs ([\element-hq#7980](matrix-org/matrix-react-sdk#7980)). Fixes element-hq#21285 and element-hq#21289.
* fallback to event text in location body when map unavailable ([\element-hq#7982](matrix-org/matrix-react-sdk#7982)). Fixes element-hq#20655.
* Send pin drop location share events ([\#7967](matrix-org/matrix-react-sdk#7967)).
* fix quicktime video thumbnailing ([\element-hq#8108](matrix-org/matrix-react-sdk#8108)). Fixes element-hq#21505.
* Fix scroll behaviour in space panel ([\element-hq#8111](matrix-org/matrix-react-sdk#8111)). Fixes element-hq#21467.
* Fix emoting with emoji or pills ([\element-hq#8105](matrix-org/matrix-react-sdk#8105)). Fixes element-hq#21497.
* Remove padding of InviteDialog & fix visual regression ([\element-hq#8076](matrix-org/matrix-react-sdk#8076)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fixes mx_MLocationBody_markerBorder ([\element-hq#8069](matrix-org/matrix-react-sdk#8069)). Fixes element-hq#21444. Contributed by @luixxiul.
* Make margin and padding of mx_InviteDialog_other consistent ([\#8063](matrix-org/matrix-react-sdk#8063)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fix freeze/crash when 1:1 calling ([\element-hq#8057](matrix-org/matrix-react-sdk#8057)). Fixes element-hq#21181.
* Don't assume that widget IDs are unique ([\#8052](matrix-org/matrix-react-sdk#8052)). Fixes element-hq#21399.
* Fix the header of Space landing page ([\element-hq#8048](matrix-org/matrix-react-sdk#8048)). Fixes element-hq#21402. Contributed by @luixxiul.
* Fix buttons alignment of Space list header ([\element-hq#8047](matrix-org/matrix-react-sdk#8047)). Fixes element-hq#21401. Contributed by @luixxiul.
* Fix null-guarding regression around reply_to_event dispatch ([\element-hq#8039](matrix-org/matrix-react-sdk#8039)).
* Fix clicking on copy link to thread wrongly opening thread ([\element-hq#8038](matrix-org/matrix-react-sdk#8038)). Fixes element-hq#20653.
* Fix regression around replying to search results ([\element-hq#8035](matrix-org/matrix-react-sdk#8035)). Fixes element-hq#21389.
* Share shared history keys in the background ([\element-hq#8031](matrix-org/matrix-react-sdk#8031)). Fixes element-hq#21192.
* Paginate responses to pinned polls ([\element-hq#8025](matrix-org/matrix-react-sdk#8025)). Fixes element-hq#21382.
* Fix incorrect usage of unstable variant of `is_falling_back` ([\element-hq#8016](matrix-org/matrix-react-sdk#8016)).
* Fix issues with ThreadSummary in msc-enabled mode ([\element-hq#8018](matrix-org/matrix-react-sdk#8018)). Fixes matrix-org/element-web-rageshakes#11401 and matrix-org/element-web-rageshakes#11400.
* Fix alignment of polls within threads ([\element-hq#8017](matrix-org/matrix-react-sdk#8017)). Fixes element-hq#21235.
* Fix issues with thread summaries being wrong or stale ([\element-hq#8015](matrix-org/matrix-react-sdk#8015)). Fixes element-hq#21363 and element-hq#21204.
* Fix button border color of LeaveSpaceDialog ([\element-hq#8010](matrix-org/matrix-react-sdk#8010)). Fixes element-hq#21365. Contributed by @luixxiul.
* Fix room list scroll jumps ([\element-hq#7991](matrix-org/matrix-react-sdk#7991)). Fixes element-hq#19322.
* Fix a variety of issues with HTML → Markdown conversion ([\element-hq#8004](matrix-org/matrix-react-sdk#8004)). Fixes element-hq#10648, element-hq#20718, element-hq#10722, element-hq#10389, element-hq#17610 element-hq#9984 and element-hq#20140.
* Wrap EventTile rather than its children in an error boundary ([\element-hq#7945](matrix-org/matrix-react-sdk#7945)).
* Normalized shortcut formatting for quote expansion control ([\element-hq#7995](matrix-org/matrix-react-sdk#7995)). Fixes element-hq#19685. Contributed by @Sinharitik589.
* Fix buttons and text layout on Security Key dialog ([\element-hq#7996](matrix-org/matrix-react-sdk#7996)). Fixes element-hq#21330. Contributed by @luixxiul.
* Fix formatting not being applied after links ([\element-hq#7990](matrix-org/matrix-react-sdk#7990)). Fixes element-hq#20091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting not being applied after links robintown/matrix-react-sdk
6 participants
@dkasak @germain-gg @MTRNord @tulir @ShadowJonathan @robintown