Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RightPanel keeps scaring me with unexpected MemberInfos #21487

Closed
ara4n opened this issue Mar 20, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#8090
Closed

RightPanel keeps scaring me with unexpected MemberInfos #21487

ara4n opened this issue Mar 20, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#8090
Labels
A-Right-Panel O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@ara4n
Copy link
Member

ara4n commented Mar 20, 2022

Steps to reproduce

So while the RightPanel's behaviour has improved a lot since #19660 was closed, I think we may have oversteered a bit in terms of tracking per-room rightpanel state at too fine a granularity.

Specifically, it's really tripping me up that rooms now remember the last MemberInfo you looked at. Repro steps:

  1. View a room
  2. Look at some random user (typically for moderation purposes)
  3. Do whatever needs to be done
  4. Look at other rooms
  5. Several hours/days elapse
  6. You happen to look at the original room again
  7. You have a massive MemberInfo staring back at you of this random user, who you no longer care about at all - causing massive cognitive dissonance. "Why is @randomidiot:matrix.org the posterchild of Matrix HQ? I don't even remember viewing their member info..."

Outcome

What did you expect?

Rooms shouldn't freak you out by showing you specific old MemberInfos when you open them; only that you were doing something in the MemberList.

What happened instead?

I keep getting freaked out by randoms jumping out at me in the RightPanel whenever I view a room.

Operating system

macOS 12.3

Application version

Nightly

How did you install the app?

Nightly

Homeserver

matrix.org

Will you send logs?

No

@ara4n ara4n added the T-Defect label Mar 20, 2022
ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 20, 2022
As bringing up a specific MemberInfo when you view a room is freaky,
even if it happened to be the last thing you were doing in that room.
Fixes element-hq/element-web#21487
@t3chguy t3chguy added the X-Needs-Product More input needed from the Product team label Mar 21, 2022
@germain-gg germain-gg added T-Defect T-Enhancement O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Right-Panel and removed T-Defect labels Mar 21, 2022
ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 21, 2022
…8090)

As bringing up a specific MemberInfo when you view a room is freaky,
even if it happened to be the last thing you were doing in that room.
Fixes element-hq/element-web#21487
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 1, 2022
* Live location sharing: live share warning in room ([\element-hq#8100](matrix-org/matrix-react-sdk#8100)).
* Add simple live share warning ([\element-hq#8066](matrix-org/matrix-react-sdk#8066)).
* extract reusable styled live beacon icon ([\element-hq#8103](matrix-org/matrix-react-sdk#8103)).
* Don't restore MemberInfo from RightPanel history when viewing a room ([\element-hq#8090](matrix-org/matrix-react-sdk#8090)). Fixes element-hq#21487.
* Allow sending files as replies as per MSC3676 ([\element-hq#8020](matrix-org/matrix-react-sdk#8020)). Fixes element-hq#7156.
* kill beacons on expiry ([\element-hq#8075](matrix-org/matrix-react-sdk#8075)).
* enable geolocation behaviour in location picker for live share type ([\element-hq#8068](matrix-org/matrix-react-sdk#8068)).
* Improve formatting features in the editor ([\#7104](matrix-org/matrix-react-sdk#7104)). Fixes element-hq#19501. Contributed by @alexanderstephan.
* Support MSC3026 busy presence ([\element-hq#8043](matrix-org/matrix-react-sdk#8043)).
* Show displayname in non-narrow thread summeries ([\element-hq#8036](matrix-org/matrix-react-sdk#8036)). Fixes element-hq#19646.
* Tweak search dialog based on new designs ([\element-hq#7980](matrix-org/matrix-react-sdk#7980)). Fixes element-hq#21285 and element-hq#21289.
* fallback to event text in location body when map unavailable ([\element-hq#7982](matrix-org/matrix-react-sdk#7982)). Fixes element-hq#20655.
* Send pin drop location share events ([\#7967](matrix-org/matrix-react-sdk#7967)).
* fix quicktime video thumbnailing ([\element-hq#8108](matrix-org/matrix-react-sdk#8108)). Fixes element-hq#21505.
* Fix scroll behaviour in space panel ([\element-hq#8111](matrix-org/matrix-react-sdk#8111)). Fixes element-hq#21467.
* Fix emoting with emoji or pills ([\element-hq#8105](matrix-org/matrix-react-sdk#8105)). Fixes element-hq#21497.
* Remove padding of InviteDialog & fix visual regression ([\element-hq#8076](matrix-org/matrix-react-sdk#8076)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fixes mx_MLocationBody_markerBorder ([\element-hq#8069](matrix-org/matrix-react-sdk#8069)). Fixes element-hq#21444. Contributed by @luixxiul.
* Make margin and padding of mx_InviteDialog_other consistent ([\#8063](matrix-org/matrix-react-sdk#8063)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fix freeze/crash when 1:1 calling ([\element-hq#8057](matrix-org/matrix-react-sdk#8057)). Fixes element-hq#21181.
* Don't assume that widget IDs are unique ([\#8052](matrix-org/matrix-react-sdk#8052)). Fixes element-hq#21399.
* Fix the header of Space landing page ([\element-hq#8048](matrix-org/matrix-react-sdk#8048)). Fixes element-hq#21402. Contributed by @luixxiul.
* Fix buttons alignment of Space list header ([\element-hq#8047](matrix-org/matrix-react-sdk#8047)). Fixes element-hq#21401. Contributed by @luixxiul.
* Fix null-guarding regression around reply_to_event dispatch ([\element-hq#8039](matrix-org/matrix-react-sdk#8039)).
* Fix clicking on copy link to thread wrongly opening thread ([\element-hq#8038](matrix-org/matrix-react-sdk#8038)). Fixes element-hq#20653.
* Fix regression around replying to search results ([\element-hq#8035](matrix-org/matrix-react-sdk#8035)). Fixes element-hq#21389.
* Share shared history keys in the background ([\element-hq#8031](matrix-org/matrix-react-sdk#8031)). Fixes element-hq#21192.
* Paginate responses to pinned polls ([\element-hq#8025](matrix-org/matrix-react-sdk#8025)). Fixes element-hq#21382.
* Fix incorrect usage of unstable variant of `is_falling_back` ([\element-hq#8016](matrix-org/matrix-react-sdk#8016)).
* Fix issues with ThreadSummary in msc-enabled mode ([\element-hq#8018](matrix-org/matrix-react-sdk#8018)). Fixes matrix-org/element-web-rageshakes#11401 and matrix-org/element-web-rageshakes#11400.
* Fix alignment of polls within threads ([\element-hq#8017](matrix-org/matrix-react-sdk#8017)). Fixes element-hq#21235.
* Fix issues with thread summaries being wrong or stale ([\element-hq#8015](matrix-org/matrix-react-sdk#8015)). Fixes element-hq#21363 and element-hq#21204.
* Fix button border color of LeaveSpaceDialog ([\element-hq#8010](matrix-org/matrix-react-sdk#8010)). Fixes element-hq#21365. Contributed by @luixxiul.
* Fix room list scroll jumps ([\element-hq#7991](matrix-org/matrix-react-sdk#7991)). Fixes element-hq#19322.
* Fix a variety of issues with HTML → Markdown conversion ([\element-hq#8004](matrix-org/matrix-react-sdk#8004)). Fixes element-hq#10648, element-hq#20718, element-hq#10722, element-hq#10389, element-hq#17610 element-hq#9984 and element-hq#20140.
* Wrap EventTile rather than its children in an error boundary ([\element-hq#7945](matrix-org/matrix-react-sdk#7945)).
* Normalized shortcut formatting for quote expansion control ([\element-hq#7995](matrix-org/matrix-react-sdk#7995)). Fixes element-hq#19685. Contributed by @Sinharitik589.
* Fix buttons and text layout on Security Key dialog ([\element-hq#7996](matrix-org/matrix-react-sdk#7996)). Fixes element-hq#21330. Contributed by @luixxiul.
* Fix formatting not being applied after links ([\element-hq#7990](matrix-org/matrix-react-sdk#7990)). Fixes element-hq#20091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Right-Panel O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants