Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Room for non-empty 1:1 chat #7982

Closed
non-Jedi opened this issue Jan 2, 2019 · 9 comments
Closed

Empty Room for non-empty 1:1 chat #7982

non-Jedi opened this issue Jan 2, 2019 · 9 comments
Labels
A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@non-Jedi
Copy link

non-Jedi commented Jan 2, 2019

This might be a duplicate, but I was unable to find an existing report.

Description

A couple times I've seen a 1:1 chat show as "Empty Room" in the sidebar room list until I open that room and speak in it. This is similar behavior to element-hq/riot-android#2671

Steps to reproduce

  • Open Riot
  • Clear client cache
  • Sometimes some 1:1 rooms show as empty room in the left sidebar list (all rooms in question are e2ee, but most 1:1 rooms I'm in are, so that might be irrelevant).
  • Open "empty" room and say something, and the room name is calculated correctly afterward.

Log: Will send after issue number created.

Version information

  • Platform: web

For the web app:

  • Browser: qutebrowser v1.5.2
  • OS: Void Linux
  • URL: riot.im/develop
@non-Jedi
Copy link
Author

non-Jedi commented Jan 2, 2019

As a process note: the template for bug reports here implies that logs should be sent before creating the issue while in Riot it says that the bug report must be created before sending logs. Should clearly indicate one or the other.

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-List labels Jan 3, 2019
@lampholder
Copy link
Member

/me wonders if this is lazy loading releated

@non-Jedi
Copy link
Author

I'd say most likely. For what it's worth, I haven't seen this again in riot web develop in the past few weeks. It may have been a transient bug. Hopefully the rageshake shows something obvious.

@Ezwen
Copy link

Ezwen commented Feb 4, 2019

I encountered this problem several times as well, along with two friends of mine. Each time, I could not find any way to make the problem disappear, and had to recreate a new 1-1 room.

I have no clue on how to reproduce the bug though :(

@szimszon
Copy link
Contributor

Have this issue as well. The weird thing is I have it in Android too...

@Eisfunke
Copy link

Still happening – a few weeks ago, an E2E 1:1 chat began showing up as »Empty Chat« for my chat partner.
Now, after reinstalling the Android app because of the re-release, it's the same for me. For both of us it's only happening on Android, on our desktop clients the chats show up correctly with the name of the other person.

@groug
Copy link

groug commented Apr 29, 2019

This happens to me and a friend 1:1 chat: we experimented a while ago to change the room's name, then removed it. It "restored" the room's name (i.e. his name from my side and my name from his side). On riot web, the room's name is correct (even after trying it on a pristine browser), on newly installed riot on Android, it says "Empty Room".

@non-Jedi
Copy link
Author

Please note that this bug-report is specifically for the in-browser version of Riot. For the bug y'all are experiencing, please see element-hq/riot-android#2671.

@turt2live
Copy link
Member

I'm presuming this is fixed by the new room list as it takes a different approach to detecting this sort of thing - if it's not, please open a reproducible case in a new issue.

su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 1, 2022
* Live location sharing: live share warning in room ([\element-hq#8100](matrix-org/matrix-react-sdk#8100)).
* Add simple live share warning ([\element-hq#8066](matrix-org/matrix-react-sdk#8066)).
* extract reusable styled live beacon icon ([\element-hq#8103](matrix-org/matrix-react-sdk#8103)).
* Don't restore MemberInfo from RightPanel history when viewing a room ([\element-hq#8090](matrix-org/matrix-react-sdk#8090)). Fixes element-hq#21487.
* Allow sending files as replies as per MSC3676 ([\element-hq#8020](matrix-org/matrix-react-sdk#8020)). Fixes element-hq#7156.
* kill beacons on expiry ([\element-hq#8075](matrix-org/matrix-react-sdk#8075)).
* enable geolocation behaviour in location picker for live share type ([\element-hq#8068](matrix-org/matrix-react-sdk#8068)).
* Improve formatting features in the editor ([\#7104](matrix-org/matrix-react-sdk#7104)). Fixes element-hq#19501. Contributed by @alexanderstephan.
* Support MSC3026 busy presence ([\element-hq#8043](matrix-org/matrix-react-sdk#8043)).
* Show displayname in non-narrow thread summeries ([\element-hq#8036](matrix-org/matrix-react-sdk#8036)). Fixes element-hq#19646.
* Tweak search dialog based on new designs ([\element-hq#7980](matrix-org/matrix-react-sdk#7980)). Fixes element-hq#21285 and element-hq#21289.
* fallback to event text in location body when map unavailable ([\element-hq#7982](matrix-org/matrix-react-sdk#7982)). Fixes element-hq#20655.
* Send pin drop location share events ([\#7967](matrix-org/matrix-react-sdk#7967)).
* fix quicktime video thumbnailing ([\element-hq#8108](matrix-org/matrix-react-sdk#8108)). Fixes element-hq#21505.
* Fix scroll behaviour in space panel ([\element-hq#8111](matrix-org/matrix-react-sdk#8111)). Fixes element-hq#21467.
* Fix emoting with emoji or pills ([\element-hq#8105](matrix-org/matrix-react-sdk#8105)). Fixes element-hq#21497.
* Remove padding of InviteDialog & fix visual regression ([\element-hq#8076](matrix-org/matrix-react-sdk#8076)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fixes mx_MLocationBody_markerBorder ([\element-hq#8069](matrix-org/matrix-react-sdk#8069)). Fixes element-hq#21444. Contributed by @luixxiul.
* Make margin and padding of mx_InviteDialog_other consistent ([\#8063](matrix-org/matrix-react-sdk#8063)). Fixes element-hq#20631. Contributed by @luixxiul.
* Fix freeze/crash when 1:1 calling ([\element-hq#8057](matrix-org/matrix-react-sdk#8057)). Fixes element-hq#21181.
* Don't assume that widget IDs are unique ([\#8052](matrix-org/matrix-react-sdk#8052)). Fixes element-hq#21399.
* Fix the header of Space landing page ([\element-hq#8048](matrix-org/matrix-react-sdk#8048)). Fixes element-hq#21402. Contributed by @luixxiul.
* Fix buttons alignment of Space list header ([\element-hq#8047](matrix-org/matrix-react-sdk#8047)). Fixes element-hq#21401. Contributed by @luixxiul.
* Fix null-guarding regression around reply_to_event dispatch ([\element-hq#8039](matrix-org/matrix-react-sdk#8039)).
* Fix clicking on copy link to thread wrongly opening thread ([\element-hq#8038](matrix-org/matrix-react-sdk#8038)). Fixes element-hq#20653.
* Fix regression around replying to search results ([\element-hq#8035](matrix-org/matrix-react-sdk#8035)). Fixes element-hq#21389.
* Share shared history keys in the background ([\element-hq#8031](matrix-org/matrix-react-sdk#8031)). Fixes element-hq#21192.
* Paginate responses to pinned polls ([\element-hq#8025](matrix-org/matrix-react-sdk#8025)). Fixes element-hq#21382.
* Fix incorrect usage of unstable variant of `is_falling_back` ([\element-hq#8016](matrix-org/matrix-react-sdk#8016)).
* Fix issues with ThreadSummary in msc-enabled mode ([\element-hq#8018](matrix-org/matrix-react-sdk#8018)). Fixes matrix-org/element-web-rageshakes#11401 and matrix-org/element-web-rageshakes#11400.
* Fix alignment of polls within threads ([\element-hq#8017](matrix-org/matrix-react-sdk#8017)). Fixes element-hq#21235.
* Fix issues with thread summaries being wrong or stale ([\element-hq#8015](matrix-org/matrix-react-sdk#8015)). Fixes element-hq#21363 and element-hq#21204.
* Fix button border color of LeaveSpaceDialog ([\element-hq#8010](matrix-org/matrix-react-sdk#8010)). Fixes element-hq#21365. Contributed by @luixxiul.
* Fix room list scroll jumps ([\element-hq#7991](matrix-org/matrix-react-sdk#7991)). Fixes element-hq#19322.
* Fix a variety of issues with HTML → Markdown conversion ([\element-hq#8004](matrix-org/matrix-react-sdk#8004)). Fixes element-hq#10648, element-hq#20718, element-hq#10722, element-hq#10389, element-hq#17610 element-hq#9984 and element-hq#20140.
* Wrap EventTile rather than its children in an error boundary ([\element-hq#7945](matrix-org/matrix-react-sdk#7945)).
* Normalized shortcut formatting for quote expansion control ([\element-hq#7995](matrix-org/matrix-react-sdk#7995)). Fixes element-hq#19685. Contributed by @Sinharitik589.
* Fix buttons and text layout on Security Key dialog ([\element-hq#7996](matrix-org/matrix-react-sdk#7996)). Fixes element-hq#21330. Contributed by @luixxiul.
* Fix formatting not being applied after links ([\element-hq#7990](matrix-org/matrix-react-sdk#7990)). Fixes element-hq#20091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants