Skip to content

Conversation

mfrasca
Copy link
Contributor

@mfrasca mfrasca commented Jun 14, 2019

I've altered where we first mention logger according to my understanding.

then, possibly one or two sections too far into the text, I realize there's questions to be posed and answered. preferably by breaking things and showing what it is that we've been using, unaware of it.

Co-Authored-By: José Valim <jose.valim@gmail.com>
@@ -215,7 +217,7 @@ Nothing really exciting happens but it shows how we can control our application.

## The application callback

TODO: what do you think of reducing amount of words, distill content, only repeat when expanding the concepts.
TODO: sorry, here I'm understanding less than beans from here on. I think that before we start modifying things, we should explain how things work in the first place. Like, how is it that the `Application.start(:kv)` tells us that `:kv` is `:already_started`? Where is that written in the code, or how is it assumed by the system? Is there anything we can change in `mix.exs`, or wherever else, that influences this? But I wish to see it in a single sentence, like "change this, and try it out". Oh, by the way, either I missed it, or we do not yet know how to reload modules, that is: compile and reload, from iex.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment in the correct place? The part we talk about Application.start(:kv) is the previous session.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the spot where I realized I could not any more follow the text.

@josevalim
Copy link
Member

I have broken the flow down a bit. Ssince this already hass a couple changes, i will merge it, but please feel free to open up another issue!

@josevalim josevalim merged commit c6f9e70 into elixir-lang:master Jun 14, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@mfrasca mfrasca deleted the patch-2 branch June 14, 2019 16:45
vladdu pushed a commit to vladdu/elixir-lang.github.com that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants