Skip to content

Update dynamic-supervisor.markdown #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Update dynamic-supervisor.markdown #1560

merged 1 commit into from
Sep 2, 2021

Conversation

mattjg908
Copy link
Contributor

Reason for change

See issue 1559

Summary of changes

This PR changes the text from:

Since we have now changed our registry to use KV.BucketSupervisor, which is registered globally, our tests are now relying on this shared supervisor even though each test has its own registry.

To:

Since we have changed our registry to use KV.BucketSupervisor, our tests are now relying on this shared supervisor even though each test has its own registry.

Before

Screen Shot 2021-09-02 at 11 43 34 PM

After

Screen Shot 2021-09-02 at 11 45 19 PM

@josevalim josevalim merged commit 64771d8 into elixir-lang:master Sep 2, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@mattjg908 mattjg908 deleted the update-dynamic-supervisor-markdown branch September 2, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjg908 @josevalim