Show charlist sigil here #13804
Merged
Show charlist sigil here #13804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 4, 2024
| @@ -60,7 +60,14 @@ Strings are always represented as themselves in the AST. | |||
|
|
|||
| ### Charlists | |||
|
|
|||
| Charlists in Elixir are written in single-quotes, such as `'foo'`. Any single-quote inside the string must be escaped with `\ `. Charlists are made of non-negative integers, where each integer represents a Unicode code point. | |||
There was a problem hiding this comment.
Because this is talking about the syntax, we should mention the single-quotes version, because that's the syntax construct. The sigil construct is mentioned elsewhere. So we should either add a mention that this construct is deprecated or remove this section, but we should not rewrite it to sigils. Does that make sense? :)
There was a problem hiding this comment.
Got it. Is the updated version good?
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.