Fix: search autocomplete result hovering causes double selection #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks! I've intentionally made mouse hover independent of the keyboard selection (at first it had a slightly different style, but decided it created too much clutter/confusions :) ) since that felt more natural to me - but this is just a personal opinion and I don't really have anything agains changing that behaviour! :D I don't think that an issue that Jose mentioned in #1028 (hover state "sticking around") exists here - at least I can't reproduce it. |
|
I see. Yeah, for me it was a bit confusing at first but I could see why it would be separated. Thanks for testing. :) Considering José is ok with this as well, I'll close this PR and change the quick-switch to work the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for @archdragon
Instead of styling the auto-complete element on-hover, it adds/removes the
selectedclass via jQuery. This way, it is not possible for the user to have multiple autocomplete results selected.I noticed this happening when you have your moues idling on the sidebar, hit s, type something and then use the arrow keys for selecting a result.