Skip to content

Add support for path dependent markdown autolink #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Add support for path dependent markdown autolink #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25b4f99
add support for path dependent markdown autolink
calvin-kargo Jun 11, 2020
4c95a3a
mix format
calvin-kargo Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/ex_doc/autolink.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ defmodule ExDoc.Autolink do
uri <- URI.parse(href),
nil <- uri.host,
true <- is_binary(uri.path),
true <- uri.path == Path.basename(uri.path),
".md" <- Path.extname(uri.path) do
if uri.path in config.extras do
without_ext = String.trim_trailing(uri.path, ".md")
md_file = Path.basename(uri.path)

if md_file in config.extras do
without_ext = String.trim_trailing(md_file, ".md")
fragment = (uri.fragment && "#" <> uri.fragment) || ""
HTML.text_to_id(without_ext) <> config.ext <> fragment
else
Expand Down
2 changes: 2 additions & 0 deletions test/ex_doc/autolink_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ defmodule ExDoc.AutolinkTest do

assert autolink(~m"[Foo](Foo Bar.md#baz)", opts) == ~m"[Foo](foo-bar.html#baz)"

assert autolink(~m"[Foo](../guide/Foo Bar.md)", opts) == ~m"[Foo](foo-bar.html)"

assert_unchanged(~m"[Foo](http://example.com/foo.md)", opts)

assert_unchanged(~m"[Foo](#baz)", opts)
Expand Down