Skip to content

Conversation

samharnack
Copy link
Contributor

No description provided.

@josevalim
Copy link
Member

Thank you @samharnack! One thing we want to do with .livemd files is to also include the original, so we can easily import them into Livebook. Can you please look into this? @wojtekmach should we also include the source .md files?

@samharnack
Copy link
Contributor Author

Will do! @josevalim do you have a preference/suggestion of where the source files should be copied or is the root fine?

@wojtekmach
Copy link
Member

wojtekmach commented Aug 25, 2021

I'm not sure I follow, in the context of livebook what is the difference between .livemd and .md and what do we need on the ExDoc side of things? My understanding is that when we work on our livebook, the file is persisted as .livemd. And when we export, we are nudged towards calling it .livemd too.

@josevalim
Copy link
Member

josevalim commented Aug 25, 2021 via email

@samharnack
Copy link
Contributor Author

samharnack commented Aug 25, 2021

IMO including the .md might get noisy so I've just copied the .livemd files. I'm happy to update the PR to include the .md files if thats the desired direction.

The .livemd files are added to the same path as the html version, the only difference is it maintains the file name casing of the original.

@wojtekmach
Copy link
Member

ok, I think I get it. Say we include ecto.livemd in Ecto docs. We already include for example the changelog. You are proposing to have all of these, right?

if so, sounds good to me.

@josevalim
Copy link
Member

Btw, for full disclosure, we will be soon launching a Livebook website and we want to add a "Run in Livebook" badge. Clicking on the badge will point to the .livemd file, which you will be able to preview and run in your favorite Livebook instance (it can be local or cloud provided). The idea is to include this badge on all Livebooks generated as part of ExDoc. :)

Co-authored-by: José Valim <jose.valim@gmail.com>
@josevalim
Copy link
Member

@samharnack good news! The tests failed, which means the current setup is enough to verify we are using the node.id. :) I have pushed a fix for the tests and we should be good to go!

@josevalim josevalim merged commit 4644b88 into elixir-lang:master Aug 26, 2021
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@samharnack
Copy link
Contributor Author

Oh wow, thank you! I was just sitting down to finish this up 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants