-
Notifications
You must be signed in to change notification settings - Fork 349
Add support for LiveBook's .livemd
Markdown files
#1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @samharnack! One thing we want to do with .livemd files is to also include the original, so we can easily import them into Livebook. Can you please look into this? @wojtekmach should we also include the source .md files? |
Will do! @josevalim do you have a preference/suggestion of where the source files should be copied or is the root fine? |
I'm not sure I follow, in the context of livebook what is the difference between |
For .livemd files, you want to import them into Livebook, so we need to
keep a copy of the original and link to it. For now, keeping the original
is fine until we figure out how to link it. Then the question is if we also
want to keep the originals for .md.
For keeping them, I think they can have the exact same path as the html
one, we just change the extension. WDYT?
--
*José Valimhttps://dashbit.co/ <https://dashbit.co/>*
|
IMO including the The |
ok, I think I get it. Say we include
if so, sounds good to me. |
Btw, for full disclosure, we will be soon launching a Livebook website and we want to add a "Run in Livebook" badge. Clicking on the badge will point to the .livemd file, which you will be able to preview and run in your favorite Livebook instance (it can be local or cloud provided). The idea is to include this badge on all Livebooks generated as part of ExDoc. :) |
Co-authored-by: José Valim <jose.valim@gmail.com>
@samharnack good news! The tests failed, which means the current setup is enough to verify we are using the node.id. :) I have pushed a fix for the tests and we should be good to go! |
💚 💙 💜 💛 ❤️ |
Oh wow, thank you! I was just sitting down to finish this up 🥳 |
No description provided.