Skip to content

Conversation

clicktodev
Copy link
Contributor

@clicktodev clicktodev commented Jan 17, 2025

Introduce a gap between tabset tabs to enhance visual spacing and improve user experience.

image

image

Copy link

@josevalim
Copy link
Member

I prefer them without spacing, so let's ask others' opinions! cc @DavidOliver

@clicktodev
Copy link
Contributor Author

clicktodev commented Jan 17, 2025

I prefer the one with spacing because it gives the elements room to breathe and is more aligned with the theme thanks to the rounded corners.
Also the original design was also broken despite the small border radius because you could see the rounded corners clashing with each other due to the lack of spacing

@josevalim
Copy link
Member

Oh, I see there is a discussion on #2023. Given both @DavidOliver and I prefer the old one, I will revert and use z-index to ensure the highlighted one is on top. Thanks @hichemfantar !

@josevalim josevalim closed this Jan 17, 2025
@clicktodev
Copy link
Contributor Author

clicktodev commented Jan 17, 2025

I wish i could change your mind on the matter because from a design standpoint, snapping together rounded corners (even tiny ones) is a no go.
Essentially no spacing works when the corners are sharp because they snap to each other.
However with round corners, the principle is to go with spacing.
@DavidOliver @josevalim @jonatanklosko @liamcmitchell

@clicktodev clicktodev deleted the bettter-tabs branch January 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants