refactor: extract minimal shared logic between HTML and EPUB formatters #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josevalim is this what you had in mind? I am doing it chunk by chunk. |
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/18201878820/artifacts/4168092755 |
josevalim
reviewed
Oct 2, 2025
josevalim
reviewed
Oct 2, 2025
|
Two minor nits and we can ship it. |
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/extract-shared-formatter-logic
branch
from
052899c to
a7e79c2
Compare
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract render_all, build_extras, and filter_list functions from HTML to shared ExDoc.Formatter module to eliminate tight coupling where EPUB directly calls HTML functions.
Changes:
This provides a foundation for additional formatters while maintaining the existing API and functionality.