Deal with http:// when guessing source_url_pattern #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
lib/ex_doc.ex
Outdated
| :error | ||
| end) | ||
| do | ||
| ( %URI{parsed_url | scheme: "https", port: 443} |
There was a problem hiding this comment.
There is no whitespace around parentheses/brackets most of the time, but here there is.
josevalim
reviewed
May 20, 2017
lib/ex_doc.ex
Outdated
|
|
||
| defp guess_url(url = <<"https://bitbucket.org/", _ :: binary>>, ref) do | ||
| append_slash(url) <> "src/#{ref}/%{path}#cl-%{line}" | ||
| defp guess_url(url, ref) when is_binary(url) do |
There was a problem hiding this comment.
What if we rely more on pattern matching and functions? Something like:
def guess_url(url, ref) do
with {:ok, host_with_path} <- http_or_https(url),
{:ok, pattern} <- known_pattern(host_with_path, ref) do
append_slash(url) <> pattern
else
_ -> url
end
end
defp http_or_https("http://" <> rest), do: {:ok, rest}
defp http_or_https("https://" <> rest), do: {:ok, rest}
defp http_or_https(_), do: :error
defp known_pattern("github.com/" <> _, ref),
do: {:ok, "blob/#{ref}/%{path}#L%{line}"}
defp known_pattern("gitlab.com/" <> _, ref),
do: {:ok, "blob/#{ref}/%{path}#L%{line}"}
defp known_pattern("bitbucket.org/" <> _, ref),
do: {:ok, "src/#{ref}/%{path}#cl-%{line}"}
defp known_pattern(_),
do: :errorThere was a problem hiding this comment.
definitely much better.
Closes elixir-lang#717 It rewrites "http" to "https" when building source_url_pattern.
|
ok. this is ready to merge |
|
❤️ 💚 💙 💛 💜 |
|
Thank you @josevalim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717
It rewrites "http" to "https" when building source_url_pattern.