Raise if version is not provided in Docs task config #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eksperimental
changed the title
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
lib/mix/tasks/docs.ex
Outdated
| end | ||
|
|
||
| defp fetch_version!(config) do | ||
| try do |
There was a problem hiding this comment.
Prefer using an implicit try rather than explicit try.
eksperimental
force-pushed
the
force_version
branch
from
aba73f6 to
cbd6b32
Compare
josevalim
reviewed
May 23, 2017
lib/mix/tasks/docs.ex
Outdated
| end | ||
|
|
||
| defp fetch_version!(config) do | ||
| Keyword.fetch!(config, :version) |
There was a problem hiding this comment.
If we are going to raise, then we should use Keyword.fetch + pattern matching.
There was a problem hiding this comment.
I.e. we shouldn't rescue exceptions. I believe when @ericmj mentioned Keyword.fetch! he was not expecting a custom error message.
There was a problem hiding this comment.
Sorry, this was really wrong. Too tired I guess 😫
|
I don't think we need a custom error message since it should always be caught by the compiler. Just using |
eksperimental
force-pushed
the
force_version
branch
from
cbd6b32 to
67b4f37
Compare
|
@ericmj It will be caught. I thought it was better to give a more meaningful message. But it's up to you guys |
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will raise with ArgumentError if :version key is not provided in config.
/cc @ericmj