[Windows] Fix unit tests #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
test/ex_doc/formatter/html_test.exs
Outdated
| generate_docs(doc_config()) | ||
|
|
||
| content = File.read!("#{output_dir()}/api-reference.html") | ||
| content = File.read!("#{output_dir()}/api-reference.html") |> normalize_eol() |
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
milmazz
force-pushed
the
unit_tests_windows
branch
from
4796243 to
854ea7f
Compare
josevalim
reviewed
May 27, 2017
test/ex_doc/formatter/epub_test.exs
Outdated
| generate_docs_and_unzip(config) | ||
|
|
||
| content = File.read!("#{output_dir()}/OEBPS/readme.xhtml") | ||
| content = "#{output_dir()}/OEBPS/readme.xhtml" |> File.read!() |> normalize_eol() |
There was a problem hiding this comment.
Do we need this? None of those seem to be asserting on new lines?
josevalim
reviewed
May 27, 2017
|
|
||
| test "site title text links to homepage_url when set" do | ||
| content = Templates.sidebar_template(doc_config(), @empty_nodes_map) | ||
| content = doc_config() |> Templates.sidebar_template(@empty_nodes_map) |> normalize_eol() |
There was a problem hiding this comment.
We don't need this. We should just remove \n from the regexes below because \s matches any space and we don't actually care in HTML if it is a new line or a regular space:
"a\r\nb" =~ ~r/a\s*b/
true
|
Hi @milmazz! I think instead of doing the eol conversion, we can adjust the regexes instead. What do you think? |
|
@josevalim Definitely better! Thanks for your suggestions. |
josevalim
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.