Throttle resize event and fix sidebar disappearance #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assets/js/helpers.js
Outdated
| return window.location.hash.replace(/^#/, '') | ||
| } | ||
|
|
||
| export function throttle (callback, limit) { |
There was a problem hiding this comment.
you could use lodash.throttle instead https://lodash.com/docs/4.17.4#throttle
There was a problem hiding this comment.
Thanks, @dignifiedquire!
I thought about it but for some reason didn't check whether we include the whole lodash or just some of its parts and decided to reinvent a wheel. I've updated the PR now.
|
Sorry for bothering, are there any more changes needed for this PR? |
|
❤️ 💚 💙 💛 💜 |
|
Sorry for dropping the ball on this one and thanks for the ping! ❤️ |
aphillipo
pushed a commit
to aphillipo/ex_doc
that referenced
this pull request
Jul 5, 2017
aphillipo
pushed a commit
to aphillipo/ex_doc
that referenced
this pull request
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #736.