Markdown modules are now 100% responsible for code #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code blocks are now handled by the markdown modules, and ExDoc doesn't do any post-processing. The modules bundled with ExDoc were updated to reflect this. The goal of this change is to make it easier to use alternative Markdown implementations. This might break compatibility for people that are already usin Markdown extensions.
|
❤️ 💚 💙 💛 💜 |
milmazz
reviewed
Aug 2, 2017
| """ | ||
| def to_html(text, _opts) do | ||
| Cmark.to_html(text) | ||
| Cmark.to_html(text) |> ExDoc.Markdown.pretty_codeblocks |
There was a problem hiding this comment.
@tmbb This is a nitpick, but it should be:
text |> Cmark.to_html() |> ExDoc.Markdown.pretty_codeblocks()| breaks: Keyword.get(opts, :breaks, false), | ||
| smartypants: Keyword.get(opts, :smartypants, true)) | ||
| Earmark.as_html!(text, options) | ||
| Earmark.as_html!(text, options) |> ExDoc.Markdown.pretty_codeblocks |
There was a problem hiding this comment.
@tmbb Another nitpick:
text |> Earmark.as_html!(options) |> ExDoc.Markdown.pretty_codeblocks()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code blocks are now handled by the markdown modules,
and ExDoc doesn't do any post-processing.
The modules bundled with ExDoc were updated to reflect this.
The goal of this change is to make it easier to use alternative Markdown
implementations.
This might break compatibility for people that are already usin Markdown
extensions.
The code for the Hoedown module wasn't changed because it already handled the postprocessing of code blocks itself.
All unit tests pass, and my visual integration test with Earmark on a real project showed no differences.