Update dependencies (earmark, excoveralls) #776
Conversation
Removes deprecation warnings
|
Hello, @dkarter! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
dkarter
force-pushed
the
update-dependencies
branch
from
10f17cc to
2b673b3
Compare
|
Not sure why this is failing on firefox tests. When I run this on my machine everything is green and gulp only runs Chrome.
Either way I don't think my changes should have affected it so there must be something wrong with the build on TravisCI. |
mix.exs
Outdated
|
|
||
| defp deps do | ||
| [{:earmark, "~> 1.1"}, | ||
| [{:earmark, "~> 1.2"}, |
There was a problem hiding this comment.
Let's not bump the requirement unless we have to because people may still rely on earlier earmark versions if using earlier elixir versions. What do you think?
There was a problem hiding this comment.
Couldn't they use the previous version of ex_doc in this case?
|
They could but unless we have a reason to bump this, we should not. We can
avoid the warnings by updating the lock file, so this change seems
unnecessary.
--
*José Valimwww.plataformatec.com.br
<http://www.plataformatec.com.br/>Founder and Director of R&D*
|
|
Why did you close it? :D Sorry if i was not clear but the lock file updates are welcome, we just don't need the mix.exs ones. :) |
|
@dkarter I pushed an update to your branch, let me know what you think. |
|
@josevalim OK that works. Thanks! |
|
Thank you! ❤️ 💚 💙 💛 💜 |
Cleans up deprecation warnings during dependency compilation.