Autolink basic/built-in types and special forms in docs #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Dec 16, 2017
| will get translated to the new href of the function. | ||
| """ | ||
| def local_doc(bin, locals) when is_binary(bin) do | ||
| def local_doc(bin, locals, extension \\ ".html", lib_dirs \\ elixir_lib_dirs()) when is_binary(bin) do |
There was a problem hiding this comment.
Kernel.SpecialForms calls are neither local as in local_doc nor remote as in elixir_functions calls, so having this logic doesn't quite fit in either function.
Another approach is to combine local_doc and elixir_functions into one function, see: https://github.com/elixir-lang/ex_doc/blob/wm-autolink-bak/lib/ex_doc/formatter/html/autolink.ex#L347
|
❤️ 💚 💙 💛 💜 |
|
Thank you @wojtekmach for taking care of many of the issues I have opened up. I wish i would have been able to test them, review them and give some feedback. It looks pretty awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679
Fixes #682