Allow custom links in Autolink.elixir_functions #813
Conversation
| fun_re = ~r{([ct]:)?(#{module_re}([a-z_]+[A-Za-z_\d]*[\\?\\!]?|[\{\}=&\\|\\.<>~*^@\\+\\%\\!-]+)/\d+)}.source | ||
| normal_link_re = ~r{(?<!\[)`\s*(#{fun_re})\s*`(?!\])}.source | ||
| custom_link_re = ~r{(?|\[(.*)\])\(`(#{fun_re})`\)}.source | ||
| re = ~r{#{custom_link_re}|#{normal_link_re}} |
There was a problem hiding this comment.
@josevalim instead of making this regex more complicated, we could process custom links in a separate pass, WDYT?
I put together a fresh project to play with this stuff, see how that 2 pass thing could look like: https://github.com/wojtekmach/autolink/blob/master/lib/autolink.ex#L95:L98 In that snippet I'm also unifying local_doc and elixir_functions and I'm still exploring whether that's a good idea, so let's ignore that for now :)
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixir-lang/ex_doc/pulls/813. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| end) | ||
| end | ||
|
|
||
| def replacement(all, match, project_funs, extension, lib_dirs, text \\ nil) do |
There was a problem hiding this comment.
Function takes too many parameters (arity is 6, max is 5).
|
@josevalim ready! we could allow custom links in other places too, e.g. for local calls, modules, erlang functions and whatnot, but maybe let's wait for use cases :) |
Fixes #622