Fix formatting typespecs #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| end | ||
| end | ||
|
|
||
| # TODO: remove when we require Elixir v1.6+ |
| end | ||
|
|
||
| @doc false | ||
| def format_and_extract_typespec_placeholders(ast, typespecs, aliases, lib_dirs) do |
There was a problem hiding this comment.
Function is too complex (CC is 10, max is 9).
There was a problem hiding this comment.
What is CC? I don't get this message
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you @whatyouhide. And here's the code if anybody is interested. https://github.com/rrrene/credo/blob/master/lib/credo/check/refactor/cyclomatic_complexity.ex
josevalim
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #831
Also general improvements (see added tests)