Use [rel="noopener"] on external links #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please no, like really no. If I want to open a new tab I will middle-click. Left-click should always only open in the same tab and it is really really irritating when a site overrides that behaviour so I have no option to open in the same tab then... |
|
Thanks, @OvermindDL1! You're right, there was no sense in changing current behaviour on links to source code. I've rebased the branch and updated the PR description accordingly. |
josevalim
approved these changes
Mar 20, 2018
whatyouhide
approved these changes
Mar 20, 2018
|
Thanks @nscyclone! 💟 |
|
@nscyclone missed you're a committer on ex_doc, sorry for the merge + usual thanks 😄 |
wojtekmach
added a commit
to hexpm/hexpm
that referenced
this pull request
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[rel="noopener"]is added to external links having[target="_blank"]to deny access towindow.opener. Here is a quick rundown on why it is important.