Fix autolinking when running as escript #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Mar 29, 2018
| path -> List.to_string(path) | ||
| end | ||
|
|
||
| if Application.get_env(:ex_doc, :running_as_escript) do |
There was a problem hiding this comment.
I'm sure there's a better way to do it, thoughts?
wojtekmach
commented
Mar 29, 2018
|
|
||
| defp elixir_lib_dir(app) do | ||
| path = | ||
| case :code.where_is_file('Elixir.Kernel.beam') do |
There was a problem hiding this comment.
unfortunately we won't be able to autolink things from Mix, IEx etc because they're not loaded.
wojtekmach
changed the title
josevalim
approved these changes
Mar 29, 2018
wojtekmach
force-pushed
the
wm-fix-autolink-escript
branch
3 times, most recently
from
749997b to
8b57640
Compare
wojtekmach
force-pushed
the
wm-fix-autolink-escript
branch
from
8b57640 to
1906574
Compare
|
I had some issues with using escript in prerelease.sh so leaving that out for now. |
|
Great job, thank you so much. Would be great if we can install ex_doc inside Earmark as a dev dependency but I guess this is just impossible (unless we render with a different markdown converter but that would be kind of not what we want ;)). Any thoughts on that? Thx again and keep your excellent work up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #840