Fix generating invalid JS when module name contains double quotes (#842) #843
Conversation
|
Hello, @arsssen! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
| end | ||
|
|
||
| defp sidebar_items_node(module_node) do | ||
| escape_quotes = &String.replace(&1, "\"", "\\\"") |
There was a problem hiding this comment.
Might be good to escape \ too in case it appears at the end of a module name (unlikely though not impossible)
There was a problem hiding this comment.
Instead of escape, I think we should call #{inspect(id)} instead of #{id} when generating the sidebar data in the first place. :) That should take care of everything.
There was a problem hiding this comment.
Another option is to call html_escape or similar.
3 participants
No description provided.