Skip to content

Link directly to page if sidebar item has no subitems #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2018
Merged

Link directly to page if sidebar item has no subitems #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
797d578
link directly to page if sidebar item has no contents
nbw May 30, 2018
92cd26c
refactor isEmptyNode
nbw May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions assets/js/template-helpers/isEmptyNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
export default function (node, options) {
var nodeItems = [
node.headers,
node.types,
node.functions,
node.macros,
node.callbacks
]

for (var i = 0; i < nodeItems.length; i++) {
if (Array.isArray(nodeItems[i]) && (nodeItems[i].length > 0)) {
return options.inverse(this)
}
}

return options.fn(this)
}
137 changes: 70 additions & 67 deletions assets/js/templates/sidebar-items.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,76 +8,79 @@
{{!-- When visiting a module page, the link to this module page
in the menu should not link to a new page, instead should link
to the top of the page itself. --}}
{{#isEmptyNode node}}
<a href="{{node.id}}.html" title="{{node.title}}">{{node.title}}</a>
{{else}}
<a href="{{node.id}}.html" title="{{node.title}}" class="expand">{{node.title}}</a>

<a href="{{node.id}}.html" title="{{node.title}}" class="expand">{{node.title}}</a>

<ul>
<li>
<a href="{{node.id}}.html#content">Top</a>
</li>

{{#isArray node.headers}}
{{#each node.headers}}
<li>
<a href="{{node.id}}.html#{{{anchor}}}">{{id}}</a>
</li>
{{/each}}
{{else}}
{{#showSummary node}}
<ul>
<li>
<a href="{{node.id}}.html#summary">Summary</a>
<a href="{{node.id}}.html#content">Top</a>
</li>
{{/showSummary}}
{{#if node.types}}
<li class="docs">
<a href="{{node.id}}.html#types" class="expand">Types</a>
<ul class="types-list deflist">
{{#each node.types}}
<li>
<a href="{{node.id}}.html#{{anchor}}">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.functions}}
<li class="docs">
<a href="{{node.id}}.html#functions" class="expand">Functions</a>
<ul class="functions-list deflist">
{{#each node.functions}}
<li>
<a href="{{node.id}}.html#{{anchor}}">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.macros}}
<li class="docs">
<a href="{{node.id}}.html#macros" class="expand">Macros</a>
<ul class="macros-list deflist">
{{#each node.macros}}
<li>
<a href="{{node.id}}.html#{{anchor}}" class="deflink">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.callbacks}}
<li class="docs">
<a href="{{node.id}}.html#callbacks" class="expand">Callbacks</a>
<ul class="callbacks-list deflist">
{{#each node.callbacks}}
<li>
<a href="{{node.id}}.html#{{anchor}}" class="deflink">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{/isArray}}
</ul>

{{#isArray node.headers}}
{{#each node.headers}}
<li>
<a href="{{node.id}}.html#{{{anchor}}}">{{id}}</a>
</li>
{{/each}}
{{else}}
{{#showSummary node}}
<li>
<a href="{{node.id}}.html#summary">Summary</a>
</li>
{{/showSummary}}
{{#if node.types}}
<li class="docs">
<a href="{{node.id}}.html#types" class="expand">Types</a>
<ul class="types-list deflist">
{{#each node.types}}
<li>
<a href="{{node.id}}.html#{{anchor}}">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.functions}}
<li class="docs">
<a href="{{node.id}}.html#functions" class="expand">Functions</a>
<ul class="functions-list deflist">
{{#each node.functions}}
<li>
<a href="{{node.id}}.html#{{anchor}}">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.macros}}
<li class="docs">
<a href="{{node.id}}.html#macros" class="expand">Macros</a>
<ul class="macros-list deflist">
{{#each node.macros}}
<li>
<a href="{{node.id}}.html#{{anchor}}" class="deflink">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{#if node.callbacks}}
<li class="docs">
<a href="{{node.id}}.html#callbacks" class="expand">Callbacks</a>
<ul class="callbacks-list deflist">
{{#each node.callbacks}}
<li>
<a href="{{node.id}}.html#{{anchor}}" class="deflink">{{id}}</a>
</li>
{{/each}}
</ul>
</li>
{{/if}}
{{/isArray}}
</ul>
{{/isEmptyNode}}
</li>
{{/each}}
</ul>