Format codebase and check formatting on CI #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 1, 2018
| assert Autolink.typespec( | ||
| quote(do: parameterized_t(foo())), | ||
| [parameterized_t: 1, foo: 0], | ||
| [] |
There was a problem hiding this comment.
Can we move at least one of those to a var so the call fits a single line?
There was a problem hiding this comment.
Would shortening the type name be a good compromise? For example t(foo())? The test description should be enough to learn that these are parameterized.
josevalim
reviewed
Aug 1, 2018
| assert Autolink.elixir_functions("`ModA.example/1` and `ModB.example/2`", [ | ||
| "ModA.example/1", | ||
| "ModB.example/2" | ||
| ]) == |
There was a problem hiding this comment.
Can we please keep this example and previous ones in the previous syntax? I.e. one argument per line with the whole list on a single line? Thanks!
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.