Pushing Earmark dependency to 1.2.5 #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @RobertDober! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
RobertDober
changed the title
josevalim
reviewed
Aug 12, 2018
mix.exs
Outdated
| defp deps do | ||
| [ | ||
| {:earmark, "~> 1.1"}, | ||
| {:earmark, "~> 1.2.5"}, |
There was a problem hiding this comment.
Shouldn't we do ~> 1.2 instead so we automatically pick 1.3 when it is out?
|
You are right, but I was surprised that 1.2.3 instead of 1.2.4 was used, probably I overlooked a thingy in |
|
Just in case if you want to merge this ;). I have corrected the version to 1.2. |
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is useful, but I saw some warning and given that 1.7 is out it might be a good idea to force a modern version of
Earmark.