Skip to content

Conversation

tmbb
Copy link
Contributor

@tmbb tmbb commented Sep 16, 2018

The new version of makeup_elixir supports correct rendering of PIDs (#PID<123.456.789>) and adds correct support for iex prompts inside strings, which can happen in IEx sessions such as this:

iex> a = "
...> line1
...> line2
...> "

mix.exs Outdated
[
{:earmark, "~> 1.2"},
{:makeup_elixir, "~> 0.7"},
{:makeup_elixir, "~> 0.10.0"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to depend on "0.10.0" and not on "0.10"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can depend on "0.10", sure.

@josevalim josevalim merged commit 56332b8 into elixir-lang:master Sep 16, 2018
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@tmbb
Copy link
Contributor Author

tmbb commented Sep 18, 2018

I don't know if this is the right place for this request, but I think you should make a patch release and change the script that builds the Elixir docs so that it uses this new release, because the new Elixir lexer actually fixes some highlighting bugs in the Elixir docs.

@josevalim
Copy link
Member

Elixir master always builds from ex_doc master. Stable updates only in a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants