Update asset build pipeline #901
Conversation
For some reason, the CommonJS-ready language files in the lib/ directory are not present in the 9.12.0 release. That's what necessitates the current convoluted build process (invoking tools/build.js and whatnot). Since there's not much [difference](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md#version-9120) between 9.11.0 and 9.12.0, it seems simpler to downgrade the dependency.
And remove same functionality from Gulp pipeline
browserslist config taken from autoprefixer config in Gulpfile
|
Hello, @gj! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
Thanks @gj, this looks amazing! Three last questions :
❤️ |
ETA: updated sizes after removing Elixir syntax highlighting import |
EPUB code highlighting doesn't work before or after this PR, but that's a bit outside the scope of this PR and should be addressed in a follow-up
|
Thanks @gj, it looks good to go. Just one last change: can you please revert decc9e7 and rebuild the assets? The Elixir syntax highlightning is not done with JS, it is done while we generate the docs using the "makeup" tool. It only supports Elixir right now but the plan is to move to it little by little. :) |
|
@josevalim haha I just noticed that too (in b44eba1) Reverted and the CI is running 😄 |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixir-lang/ex_doc/pulls/901. |
|
❤️ 💚 💙 💛 💜 |
2 participants
Closes #873
Regarding @josevalim's comment, the coupling between Gulp, Webpack, and Karma made it a bit awkward to update Webpack in isolation.
This PR is all about feature parity, with one exception: there's no more equivalent of the
npm run cleanGulp task that removed build artifacts. I set Webpack up to automatically remove build artifacts before executing a production build, which retains most of the same functionality as before. If a script solution is preferably to manual rimraffing, I can add a little script for thenpm run cleanfunctionality.If this PR is accepted, I would like to simplify the test setup in a followup PR. Right now we're loading a full browser environment but then only running unit tests, which seems like a bit of overkill to me.
npm auditfound 84 vulnerabilities (36 low, 24 moderate, 23 high, 1 critical)found 2 low severity vulnerabilities