Rewrite Autolink tests to use project_doc/2 #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, remove Autolink.project_doc/4 Closes elixir-lang#904
eksperimental
force-pushed
the
rewrite_autolink_tests
branch
from
c9262ef to
1f83dd1
Compare
eksperimental
commented
Oct 21, 2018
| assert Autolink.project_doc("[the `:erlang` module](other.html)", %{}) == | ||
| "[the `:erlang` module](other.html)" | ||
|
|
||
| assert Autolink.erlang_modules("`:erlang`") == "[`:erlang`](#{@erlang_docs}erlang.html)" |
There was a problem hiding this comment.
duplicated tests when converted to project_doc/2
eksperimental
commented
Oct 21, 2018
| assert Autolink.project_doc("[the `:erlang.apply/2` function](other.html)", %{}) == | ||
| "[the `:erlang.apply/2` function](other.html)" | ||
|
|
||
| assert Autolink.erlang_functions("`:erlang`") == "`:erlang`" |
There was a problem hiding this comment.
duplicated tests when converted to project_doc/2
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, remove Autolink.project_doc/4
Closes #904