Added ARIA-label to the search button #979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged by hand, thank you for those commits, they are veery appreciated! |
|
@josevalim Sure thing - I wasn't sure whether or not all of these assets etc. should be included in the PR though. |
|
@kennethlarsen theoretically your compilation should have resulted in the same assets. This means we are either getting different outcomes on every compilation (or on different OSes or JS versions) or that someone forget to compile them after changing. :) But yeah, they are not necessary in this change but it is not your fault they were listed as changed. Ideally they wouldn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an aria-label for the search button in the sidebar. This is necessary for people using assistive technologies to understand what the button actually does.