Skip to content

Conversation

nikfp
Copy link
Contributor

@nikfp nikfp commented Oct 13, 2025

Hi, and thanks for making this great package! I'm really liking it and have been using it for a while.

I was looking for a way to customize the behavior of the code lens test runner and found the extension point that I needed in the source. I changed the way elixirls commands are passed in during setup to keep the default behavior unless the end user changes the commands key in the elixirls config. The behavior I'm proposing will merge configs, keeping the default unless the key is overwritten.

I also updated the README to reflect this change and document how to use it.

I hope you will consider merging it in. This was needed to allow my customization, which was to move the test output from the split terminal it defaults to, into a floating terminal window that I set up.

I tested both the default and the custom function I created and it works great.

Also note that the formatter pass caught a few things and updated them, just whitespace issues from what I can see. Nothing functional.

Let me know if you have any questions or need anything else from me!

@nikfp nikfp changed the title Allowing extension point for lsp specific actions feat: Allowing extension point for lsp specific actions Oct 13, 2025
@nikfp nikfp changed the title feat: Allowing extension point for lsp specific actions feat: allowing extension point for lsp specific actions Oct 13, 2025
@mhanberg
Copy link
Collaborator

Seems simple enough to merge, but I'm hesitant to merge more Elixir LS stuff, as we're focusing on Expert.

But I think you're formatter was not using the stylua config, as it's failing the linter check.

@nikfp
Copy link
Contributor Author

nikfp commented Oct 13, 2025

Seems simple enough to merge, but I'm hesitant to merge more Elixir LS stuff, as we're focusing on Expert.

I was thinking that might be your response to be honest. I'm OK with keeping my fork of the repo as the remote for the plugin I'm using until Expert starts coming up to feature parity and I can switch over. And hopefully I can find a place to contribute to Expert as well, assuming I can grok what's happening in that repo and be useful....

@mhanberg
Copy link
Collaborator

I'll merge it, just fix the formatting and I'll cut a release.

@nikfp
Copy link
Contributor Author

nikfp commented Oct 14, 2025

Noted. I ran Stylua in the repo and pushed the change, should be good to go. Much appreciated for working with me on this, thanks!

BTW, I also want to thank you for the work you've done community wide. It's no small task to take on what you have, and I and many others are very grateful.

@mhanberg mhanberg merged commit 96d9687 into elixir-tools:main Oct 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants