-
-
Notifications
You must be signed in to change notification settings - Fork 9
refactor!: reorganize configuration settings #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that I can't currently run NextLS and merging this should wait :) |
|
Nice!! I think I have a hack to get it to work if you want to try, someone is currently seeing if they can fix it to run the new prebuilt binaries. If you download the binary from the releases page for your OS and architecture and replace the For example on my macbook, the path is so if you download the new binary, rename to |
|
@zachallaun friendly reminder to rebase and test this and we get it merged and released 💅 |
1ffddd1 to
22fba70
Compare
|
@mhanberg Apologies for the delay! This should now be ready for review. |
22fba70 to
22b34f3
Compare
|
Fixed! 22fba70..22b34f3 |
package.json
Outdated
| "properties": { | ||
| "elixir-tools.nextLS.enable": { | ||
| "type": "boolean", | ||
| "default": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also on main i changed this to true
package.json
Outdated
| "properties": { | ||
| "elixir-tools.credo.enable": { | ||
| "type": "boolean", | ||
| "default": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on main i changed this to false
This PR organizes the extension's config settings and renames the Next LS setting prefix to improve setting legibility.
Summary of changes:
"order"attribute to the*.enableproperties so that they come first."elixir-tools.nextls.*"to"elixir-tools.nextLS.*". This causes properties to render as "Next LS: *" instead of "Nextls: *".Before:
After: