Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that Map update operator syntax only works for existing keys #2008

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@delta1
Copy link
Contributor

delta1 commented Oct 1, 2019

Add a note and example that Map update operator only works to update an existing key, and an example to use Map.put/3 for a new key instead.

…a key, and an example to use Map.put/3 for a new key instead.
@delta1 delta1 requested a review from elixirschool/english as a code owner Oct 1, 2019
Copy link
Member

doomspork left a comment

@delta1 this is an great addition, thank you and welcome 😁Could you make one small change before we merge this? At the top of the file there is some meta data including the 1.2.5 version. Since we want your changes to be translated let's bump this the version to 1.3.0.

@delta1

This comment has been minimized.

Copy link
Contributor Author

delta1 commented Oct 3, 2019

hey @doomspork ! it's a pleasure, thanks for this great resource, the feedback, and the warm welcome :D

I have bumped the version - hope that helps!

@delta1 delta1 requested a review from doomspork Oct 3, 2019
@doomspork doomspork merged commit 97a28cf into elixirschool:master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@doomspork

This comment has been minimized.

Copy link
Member

doomspork commented Oct 3, 2019

Thank you @delta1 ❤️ both of your PRs were great additions. I hope you'll stick around and continue your awesome contributions.

If you're interested in joining us on Slack you can grab an invite over at http://admissions.elixirschool.com though you may need to give GitHub some time to update (we check for contributions to eliminate spam).

@delta1

This comment has been minimized.

Copy link
Contributor Author

delta1 commented Oct 7, 2019

Hey @doomspork you're most welcome, thank you too for the friendly atmosphere and this great project! I don't use slack all that much but I'll try hop on occasionally - and I'll definitely be around to contribute some more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.