Skip to content

Conversation

k-bx
Copy link

@k-bx k-bx commented Nov 19, 2018

Not sure how to test this locally, couldn't find "hacking" doc. Asked on Slack.

@lukewestby
Copy link
Member

lukewestby commented Nov 19, 2018

@k-bx can you open an issue instead? I don't think function should ever see null so the fix might be more complicated and potentially involve the compiler.

@evancz
Copy link
Member

evancz commented Nov 19, 2018

Yes, please open an issue with an http://sscce.org/

@evancz evancz closed this Nov 19, 2018
@k-bx
Copy link
Author

k-bx commented Nov 21, 2018

Done in https://github.com/elm/compiler/issues/1856 . I believe this fix is correct. The offender code is doing Date.prototype._nth = null and it breaks things (introducing a null "object"). Also, I've tested this patch and it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants