Update with master #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.2: Fix undefined behavior (left shift of negative number)
* PHP-8.3: Fix undefined behavior (left shift of negative number)
Fixes GH-13970 Closes GH-14105 We cannot validate at compile-time for multiple reasons: * Evaluating the argument naively with zend_get_attribute_value can lead to code execution at compile time through the new expression, leading to possible reentrance of the compiler. * Even if the evaluation was possible, it would need to be restricted to the current file, because constant values coming from other files can change without affecting the current compilation unit. For this reason, validation would need to be repeated at runtime anyway. * Enums cannot be instantiated at compile-time (the actual bug report). This could be allowed here, because the value is immediately destroyed. But given the other issues, this won't be needed. Instead, we just move it to runtime entirely. It's only needed for ReflectionAttribute::newInstance(), which is not particularly a hot path. The checks are also simple.
* PHP-8.2: Delay #[Attribute] arg validation until runtime
* PHP-8.3: Delay #[Attribute] arg validation until runtime
* PHP-8.3: Fix attribute test on newer branches
* PHP-8.2: Fix persisting of inherited class constants
* PHP-8.3: Fix persisting of inherited class constants
* PHP-8.3: Add test for GH-14109
This field is only ever written to, but never read.
There's no point in checking the length, this just wastes time.
* Fix prototype for trait methods Fixes GH-14009 * Clenup do_inheritance_check_on_method() Remove wierd checks and define the behavior by explicit set of flags * Fix naming and indentation --------- Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
* PHP-8.2: Fix prototype for trait methods (#14148)
* PHP-8.3: Fix prototype for trait methods (#14148)
_bc_do_sub now uses SIMD to perform calculations at high speed. Moved the macros used for SIMD to `private.h`, and added some constants and macros.
The bug was introduced in c6b75f9
github-actions
bot
added
Extension: pgsql
Extension: phar
Extension: posix
Extension: random
Extension: readline
Extension: reflection
Extension: session
Extension: simplexml
Extension: snmp
Extension: soap
Extension: sockets
Extension: sodium
Extension: spl
Extension: sqlite3
Extension: standard
Extension: tidy
Extension: tokenizer
Extension: xml
Extension: xmlreader
Extension: xsl
Extension: zend_test
Extension: zip
Extension: zlib
SAPI: apache2handler
SAPI: cgi
SAPI: cli
SAPI: fpm
SAPI: fuzzer
SAPI: litespeed
SAPI: phpdbg
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.