Skip to content

Conversation

kermorgant
Copy link
Contributor

This PR adds a dedicated function to execute the "complete_constructor" transform.

"complete_constructor" is already available through the context menu which is fine, but having a dedicated function can also be useful (for keybindings for example).

@zonuexe
Copy link
Member

zonuexe commented Aug 22, 2018

@kermorgant
I added "Require review from Code Owners" to Branch protection rules for merging into master.
This is not to disturb your activities but to visualize "I want other members to review".

You can approve your own PR and merge it. You do not need to ask my approval every time to add features at this level, but please do not hesitate to assign me if you want someone's review.

@kermorgant kermorgant merged commit 705790f into emacs-php:master Aug 22, 2018
@kermorgant kermorgant deleted the complete-constructor branch September 16, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants