Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid writing JSHint ignore on generated files #117

Closed
alexlafroscia opened this issue Jul 26, 2016 · 1 comment
Closed

Avoid writing JSHint ignore on generated files #117

alexlafroscia opened this issue Jul 26, 2016 · 1 comment

Comments

@alexlafroscia
Copy link
Contributor

alexlafroscia commented Jul 26, 2016 •
edited
Loading

I'm using ESLint for my Ember project and really wish the blueprints here wouldn't dump

/* jshint expr:true */

at the top of all of my test files. I understand why it's done, but it's a bit annoying for those of us not using JSHint.

It should be possible to only add it if the ember-cli-jshint package is installed (or maybe try to detect ember-cli-eslint and prevent writing it if it's present). It seems like it should be possible to use custom file tokens to contain the JSHint expression (or nothing) and use the blueprint system to write the line (or not) dynamically.
@philtobias philtobias mentioned this issue Aug 1, 2016
Merged
@Dhaulagiri
Copy link
Contributor

Fixed by #118

@rwjblue rwjblue closed this as completed Nov 3, 2016
Turbo87 pushed a commit that referenced this issue Oct 24, 2018
@dependabot @Turbo87
Bump lerna-changelog from 0.8.0 to 0.8.2 (#295)
643baae 
Bumps [lerna-changelog](https://github.com/lerna/lerna-changelog) from 0.8.0 to 0.8.2.
<details>
<summary>Release notes</summary>

*Sourced from [lerna-changelog's releases](https://github.com/lerna/lerna-changelog/releases).*

> ## v0.8.2
> #### 🐛 Bug Fix
> * [#125](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/125) Fix `nextVersion` config handling ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🏠 Internal
> * [#124](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/124) yarn: Add `integrity` hashes ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 1
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> ## v0.8.1
> #### 🚀 Enhancement
> * [#117](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/117) Allow "Unreleased" commit group to be renamed ([[**alex-pex**](https://github.com/alex-pex)](https://github.com/alex-pex))
> 
> #### 📝 Documentation
> * [#120](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/120) Add monorepo support docs ([[**jonaskello**](https://github.com/jonaskello)](https://github.com/jonaskello))
> 
> #### Committers: 2
> - Alexandre Paixao ([[**alex-pex**](https://github.com/alex-pex)](https://github.com/alex-pex))
> - Jonas Kello ([[**jonaskello**](https://github.com/jonaskello)](https://github.com/jonaskello))
> 
</details>
<details>
<summary>Changelog</summary>

*Sourced from [lerna-changelog's changelog](https://github.com/lerna/lerna-changelog/blob/master/CHANGELOG.md).*

> ## v0.8.2 (2018-10-14)
> 
> #### 🐛 Bug Fix
> * [#125](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/125) Fix `nextVersion` config handling ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🏠 Internal
> * [#124](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/124) yarn: Add `integrity` hashes ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 1
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> 
> ## v0.8.1 (2018-10-10)
> 
> #### 🚀 Enhancement
> * [#117](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/117) Allow "Unreleased" commit group to be renamed ([[**alex-pex**](https://github.com/alex-pex)](https://github.com/alex-pex))
> 
> #### 📝 Documentation
> * [#120](https://github-redirect.dependabot.com/lerna/lerna-changelog/pull/120) Add monorepo support docs ([[**jonaskello**](https://github.com/jonaskello)](https://github.com/jonaskello))
> 
> #### Committers: 2
> - Alexandre Paixao ([[**alex-pex**](https://github.com/alex-pex)](https://github.com/alex-pex))
> - Jonas Kello ([[**jonaskello**](https://github.com/jonaskello)](https://github.com/jonaskello))
</details>
<details>
<summary>Commits</summary>

- [`8ae7803`](lerna/lerna-changelog@8ae7803) v0.8.2
- [`01ac435`](lerna/lerna-changelog@01ac435) Update Changelog
- [`17b2a9c`](lerna/lerna-changelog@17b2a9c) Merge pull request [#125](https://github-redirect.dependabot.com/lerna/lerna-changelog/issues/125) from Turbo87/config-fix
- [`dfe0b1d`](lerna/lerna-changelog@dfe0b1d) Fix `nextVersion` config handling
- [`958dc28`](lerna/lerna-changelog@958dc28) Merge pull request [#124](https://github-redirect.dependabot.com/lerna/lerna-changelog/issues/124) from Turbo87/integrity
- [`e135748`](lerna/lerna-changelog@e135748) yarn: Add `integrity` hashes
- [`17c835d`](lerna/lerna-changelog@17c835d) v0.8.1
- [`15b8076`](lerna/lerna-changelog@15b8076) Update Changelog
- [`35b6fa8`](lerna/lerna-changelog@35b6fa8) Add monorepo support docs ([#120](https://github-redirect.dependabot.com/lerna/lerna-changelog/issues/120))
- [`6fc2941`](lerna/lerna-changelog@6fc2941) Merge pull request [#117](https://github-redirect.dependabot.com/lerna/lerna-changelog/issues/117) from alex-pex/feature/set-next-version
- Additional commits viewable in [compare view](lerna/lerna-changelog@v0.8.0...v0.8.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=lerna-changelog&package-manager=npm_and_yarn&previous-version=0.8.0&new-version=0.8.2)](https://dependabot.com/compatibility-score.html?dependency-name=lerna-changelog&package-manager=npm_and_yarn&previous-version=0.8.0&new-version=0.8.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

Dependabot will **not** automatically merge this PR because this dependency is pre-1.0.0.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @alexlafroscia @Dhaulagiri