Minor fixes #64
Merged
Minor fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
approved these changes
Feb 9, 2018
|
Still failing. After looking a bit closer, I think this may be due to dependency drift and us still testing against Phantom 1.x which I don't think we need to continue to do. We can likely drop this line: ember-asset-loader/.travis.yml Line 18 in f8f1a44 |
|
No big deal, these were just things I noticed when browsing the project. (Incidentally, spurious failures like this is why I disagree with the approach of not locking down dependencies in CI.) |
Noted (again) |
|
CI was fixed (thanks @lennyburdette!) in #66, this should pass with a rebase... |
The value after the type in a `@return` annotation is the description of the returned value, but this was being used as if it were a `@param`. Since `app` by itself is not a very good description, I just removed it.
|
Okay, rebased. |
rwjblue
approved these changes
Jun 7, 2018
|
Thank you @eventualbuddha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All pretty minor. Each commit fixes one thing.