add link rel canonical for release url #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddjordan
changed the title
toddjordan
force-pushed
the
add-link-canonical-for-release
branch
from
444719c to
6eca4f4
Compare
toddjordan
changed the title
toddjordan
commented
Jan 4, 2018
app/templates/head.hbs
Outdated
| @@ -1,7 +1,6 @@ | |||
| <title>{{model.title}}</title> | |||
|
|
|||
| <link rel="dns-prefetch" href="{{cdnDomain}}" > | |||
There was a problem hiding this comment.
actually this may need a bug from before, and need to be model.cdnDomain. will check and update if necessary.
|
Can we add a test for this? |
sivakumar-kailasam
requested changes
Jan 4, 2018
app/templates/head.hbs
Outdated
| @@ -1,7 +1,6 @@ | |||
| <title>{{model.title}}</title> | |||
|
|
|||
| <link rel="dns-prefetch" href="{{cdnDomain}}" > | |||
|
yeah, will see what I can do for a test. Should be able to assert on it with an acceptance test |
toddjordan
force-pushed
the
add-link-canonical-for-release
branch
from
6eca4f4 to
5f3596a
Compare
sivakumar-kailasam
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass at adding link canonical tag to api docs in support of
releaseurlPart of addressing #407