skip tests that are broken because of invalid data in production #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests currently rely on downloading data from the real API (a problem but something we have a plan for 馃檲) but there was an issue with a recent deployment that caused some URLs to fail
e.g. https://api.emberjs.com/ember/3.13/functions/@ember%2Fapplication/getOwner works but https://api.emberjs.com/ember/3.12/functions/@ember%2Fapplication/getOwner does not
To unblock all PRs to this repo I'm just skipping tests that rely on that data and duplicating them to use more modern versions that aren't broken 馃憤 we can un-skip the old tests once the issue with the production data is fixed