Skip to content

Decode character entities given in descriptions. #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019

Conversation

toddjordan
Copy link
Contributor

This is a patch for emberjs/ember.js#18063 which lets us provide yuidoc special characters as html character code entities and decodes them before we apply highlightjs and markdown processing.

Here's a preview of the screen for the above issue
image

@toddjordan toddjordan force-pushed the decode-descriptions branch 2 times, most recently from 92d5be5 to 86e5bb6 Compare May 31, 2019 18:43
@jenweber
Copy link
Contributor

Waiting for @sivakumar-kailasam to chime in before we merge this

@sivakumar-kailasam
Copy link
Member

This is exactly what I had in mind.🙏 @toddjordan could you make the test pass before merging this though?

@toddjordan toddjordan force-pushed the decode-descriptions branch from 86e5bb6 to e8049dc Compare May 31, 2019 18:58
@toddjordan
Copy link
Contributor Author

@sivakumar-kailasam so husky was preventing the build from passing because it was adjusting the indentation of a switch statement in the file, so for now I'm removing husky so we can get this in.

@toddjordan
Copy link
Contributor Author

if someone has a husky config that plays well with our eslint config we can re-enable it

@sivakumar-kailasam
Copy link
Member

SGTM

@toddjordan toddjordan merged commit 2616e4e into ember-learn:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants